Adding user-agent metrics for flexible checksums #3851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
landonxjames
force-pushed
the
landonxjames/flex-ua
branch
from
6b09dd9
to
bf27b74
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
landonxjames
force-pushed
the
landonxjames/flex-ua
branch
from
bf27b74
to
aec2180
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
reviewed
Sep 30, 2024
aws/sdk-codegen/src/test/kotlin/software/amazon/smithy/rustsdk/HttpChecksumTest.kt
Show resolved
Hide resolved
landonxjames
force-pushed
the
landonxjames/flex-ua
branch
from
4252c5b
to
d714eaa
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add user-agent metrics for checksum configs/algorithms.
Description
Add user-agent metrics for checksum configs/algorithms.
Testing
Add tests to
HttpChecksumTest.ktto ensure the the user-agent features are set for configs and the selected algorithm. Note that the canary is still failing for this PR for the same reasons that it is in #3845By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.