-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC30: Add test that runs with unstable flag on #2851
base: main
Are you sure you want to change the base?
RFC30: Add test that runs with unstable flag on #2851
Conversation
RUSTFLAG="--cfg aws_sdk_unstable"
to some ci-scripts
RUSTFLAG="--cfg aws_sdk_unstable"
to some ci-scriptsRUSTFLAG="--cfg aws_sdk_unstable"
to some ci-scripts
I think something like this is necessary. We probably want a single parallel task to sanity check everything with the flag enabled but do most testing with it disabled. Need to think about this. The main issue is the coverage that we're losing with the flag disabled (which is, of course, where most customers are going to be) Maybe one CI target |
I added I think it's working. |
I got 2 errors.
and
Since I made no changes to both jobs, I have no idea where it's coming from :( |
RUSTFLAG="--cfg aws_sdk_unstable"
to some ci-scripts
I think this one's ready for review. |
Motivation and Context
This is a sub-PR of #2615.
Changes
It adds
test-with-serde
check in github actions, which runs all the tests withRUSTFLAG="--cfg aws_sdk_unstable"
env variable.We need this to run tests with unstable feature enabled.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.