chore: scrub public APIs #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajtodd
approved these changes
Jul 18, 2023
| @@ -15,6 +16,7 @@ import aws.smithy.kotlin.runtime.io.Handler | |||
| /** | |||
| * Generic HTTP service exception | |||
| */ | |||
| @InternalApi | |||
| public class HttpResponseException : SdkBaseException { | |||
There was a problem hiding this comment.
correctness: This would be correctly public without the annotation (not that we use this in AWS side but for generic smithy services if it's wired up it's an expected exception/wrapper).
There was a problem hiding this comment.
Good point, will restore full public visibility.
|
Kudos, SonarCloud Quality Gate passed!
|
lauzadis
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Addresses aws-sdk-kotlin#947
Description of changes
This change makes a whole bunch of classes, interfaces, and methods
@InternalApi. Most of these changes seemed obviously correct (to me) but I may have been overzealous in places so double-check my work.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.