fix: model test utils serviceName bug #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbotsf
approved these changes
Jun 28, 2023
lauzadis
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
I'd recommend removing the changelog, since this is just changing a test utility and not customer-facing.
There was a problem hiding this comment.
Will it still allow me to merge?
There was a problem hiding this comment.
Yep, you just have to add the no-changelog label on GitHub (tab to the right)
0marperez
added
the
no-changelog
0marperez
added
no-changelog
0marperez
added
no-changelog
…route53-custom-error-unmarshalling
|
Kudos, SonarCloud Quality Gate passed!
|
0marperez
added a commit
that referenced
this pull request
Jun 29, 2023
This reverts commit afb36c8.
aajtodd
pushed a commit
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue with utility. SDK ID for
route 53requires space but service name can't have space, i.e.route53Issue #
No Issue available (Will make one if required)
Description of changes
It solves the problem if the utility not working when it comes to route 53
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.