Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add OkHttp 4.x to transformation configuration #1151

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix: Add OkHttp 4.x to transformation configuration #1151

merged 1 commit into from
Sep 13, 2024

Conversation

lauzadis
Copy link
Contributor

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lauzadis lauzadis requested a review from a team as a code owner September 13, 2024 20:17
@lauzadis lauzadis added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Sep 13, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@lauzadis lauzadis added acknowledge-api-break Acknowledge that a change is API breaking and may be backwards-incompatible. Review carefully! acknowledge-artifact-size-increase and removed acknowledge-api-break Acknowledge that a change is API breaking and may be backwards-incompatible. Review carefully! labels Sep 13, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions GitHub Actions
Copy link

Affected Artifacts

Significantly increased in size

Artifact Pull Request (bytes) Latest Release (bytes) Delta (bytes) Delta (percentage)
http-client-engine-okhttp4-jvm.jar 14,129 (does not exist) 14,129 NaN%
Changed in size
Artifact Pull Request (bytes) Latest Release (bytes) Delta (bytes) Delta (percentage)
test-suite-jvm.jar 97,965 97,844 121 0.12%
http-client-engine-okhttp-jvm.jar 102,668 102,739 -71 -0.07%

@github-actions GitHub Actions
Copy link

Affected Artifacts

Significantly increased in size

Artifact Pull Request (bytes) Latest Release (bytes) Delta (bytes) Delta (percentage)
http-client-engine-okhttp4-jvm.jar 14,129 (does not exist) 14,129 NaN%
Changed in size
Artifact Pull Request (bytes) Latest Release (bytes) Delta (bytes) Delta (percentage)
test-suite-jvm.jar 97,965 97,844 121 0.12%
http-client-engine-okhttp-jvm.jar 102,668 102,739 -71 -0.07%

@lauzadis lauzadis merged commit 9fcea26 into main Sep 13, 2024
26 of 31 checks passed
@lauzadis lauzadis deleted the fix-transform branch September 13, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0marperez 0marperez 0marperez approved these changes

@ianbotsf ianbotsf ianbotsf approved these changes

Assignees
No one assigned
Labels
acknowledge-artifact-size-increase no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lauzadis @0marperez @ianbotsf