feat: add support for string arrays in rules engine parameters & support for operationContextParams trait #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ianbotsf
approved these changes
Jul 11, 2024
Comment on lines
46
to
48
| is ArrayValue -> values.joinToString(",", "mutableListOf(", ")") { value -> | ||
| value.expectStringValue().value.doubleQuote() | ||
| } |
Comment on lines
135
to
141
| is ArrayNode -> { | ||
| writer.writeInline( | ||
| v.elements.joinToString(",", "mutableListOf(", ")") { element -> | ||
| element.expectStringNode().value.doubleQuote() | ||
| }, | ||
| ) | ||
| } |
There was a problem hiding this comment.
Nit: Outer braces are unnecessary for single statement branches
Comment on lines
46
to
48
| is ArrayValue -> values.joinToString(",", "mutableListOf(", ")") { value -> | ||
| value.expectStringValue().value.doubleQuote() | ||
| } |
There was a problem hiding this comment.
Question: Why a mutable list?
There was a problem hiding this comment.
+1, I believe it can be non-mutable
Comment on lines
46
to
48
| is ArrayValue -> values.joinToString(",", "mutableListOf(", ")") { value -> | ||
| value.expectStringValue().value.doubleQuote() | ||
| } |
There was a problem hiding this comment.
Nit: This general pattern of serializing node values to a string of double-quoted values is repeated multiple times. We should commonize it into a single function (perhaps an extension method on List<Value>).
lauzadis
approved these changes
Jul 12, 2024
Comment on lines
46
to
48
| is ArrayValue -> values.joinToString(",", "mutableListOf(", ")") { value -> | ||
| value.expectStringValue().value.doubleQuote() | ||
| } |
There was a problem hiding this comment.
+1, I believe it can be non-mutable
This comment has been minimized.
This comment has been minimized.
lauzadis
approved these changes
Jul 17, 2024
Affected ArtifactsNo artifacts changed size |
0marperez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
Add support for string arrays in rules engine parameters
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.