feat: add DSL markers to codegenned structure builders #1065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Resolves #428
Description of changes
Calls within nested DSL functions will resolve an implicit receiver from anywhere up the hierarchy, enabling bad calls like this one:
In the above example, setting
grantRead
from withincreateBucketConfiguration
should be prohibited becausegrantRead
is a member ofCreateBucketRequest.Builder
, notCreateBucketConfiguration.Builder
.This change introduces a new DSL marker annotation
@SdkDsl
which is applied to every codegenned structure builder. Code like the above example now fails to compile.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.