Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: replace Snyk with GitHub Dependabot #1059

Merged
merged 3 commits into from
Apr 2, 2024
Merged

misc: replace Snyk with GitHub Dependabot #1059

merged 3 commits into from
Apr 2, 2024

Conversation

lauzadis
Copy link
Contributor

@lauzadis lauzadis commented Mar 29, 2024

This PR replaces use of Snyk with GitHub Dependabot. Dependabot is already enabled on our repositories but does not track our Gradle dependencies by default.

To enable tracking those, we need to manually submit our dependencies to Dependabot for scanning, which is done using a GitHub Action called gradle/actions/dependency-submission@v3.

This action only needs to run on pushes to the main branch. Running the action on any other branch will result in a no-op with this message: The snapshot was accepted, but it is not for the default branch. It will not update dependency results for the repository.

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lauzadis lauzadis changed the title misc: remove Snyk misc: replace Snyk with GitHub Dependabot Mar 29, 2024
@lauzadis lauzadis added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Mar 29, 2024
@lauzadis lauzadis marked this pull request as ready for review March 29, 2024 20:06
@lauzadis lauzadis requested a review from a team as a code owner March 29, 2024 20:06
on:
push:
branches: [ main ]

Copy link
Contributor

@0marperez 0marperez Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: the workflow won't run during pull requests like snyk, is this intentional?

@lauzadis lauzadis merged commit 1663a0d into main Apr 2, 2024
13 checks passed
@lauzadis lauzadis deleted the misc-remove-snyk branch April 2, 2024 15:19
sullis pushed a commit to sullis/smithy-kotlin that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants