Add dns wildcarding #615
Open
Add dns wildcarding #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wadey
reviewed
Dec 19, 2021
|
Can you update examples/config.yml with the new config options? (They can be commented out by default) |
aaronstillwell
commented
Dec 20, 2021
|
Very excited for this feature! |
jstasiak
approved these changes
Apr 3, 2023
| @@ -33,6 +33,8 @@ lighthouse: | |||
| # The DNS host defines the IP to bind the dns listener to. This also allows binding to the nebula node IP. | |||
| #host: 0.0.0.0 | |||
| #port: 53 | |||
| #wildcard: true # Enable wildcarding on hosts e.g allowing my-app.my-host.nebula to resolve to the IP for my-host.nebula | |||
| #wildcard_limit: 5 # Limit of number of possible subdomains | |||
There was a problem hiding this comment.
I'd rephrase this to something like # The maximum supported subdomain depth or something. "number of possible" subdomains sounds to me like it would limit the number of any level subdomains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt at implementing DNS wildcard support. The use case in mind is for those of us who wish to use nebula's DNS in conjunction with virtual hosts.
At the moment, say we have a server
my-server.nebula, it is not possible to use virtual hosts to have, for example multiple apps served atapp-1.my-server.nebula,app-2.my-server.nebulaetc.This initial (naive) implementation can be enabled with the new config options as seen below.
This config is global and doesn't support per-host or per-group enabling. I welcome discussion on the proposed feature and its implementation as-is as well as commentary around the desired configuration of the feature.
Relevant slack discussion: https://nebulaoss.slack.com/archives/CRWJJM52B/p1639478617050700