Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a skeleton for Linker Plugin #508

Closed
wants to merge 2 commits into from
Closed

Conversation

arpita184
Copy link
Contributor

This is a skeleton for a linker plugin - A plugin that will link feature flags to their server counterparts.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

  1. In the build.gradle.kts file, the intellij block can be simplified by using the intellij extension function provided by the IntelliJ Gradle Plugin. This function allows you to configure the IntelliJ plugin version, target IDE platform, and plugin dependencies in a more concise way. Here's an example of how the intellij block can be simplified:
intellij {
    version.set("2022.2.5")
    type.set("IC") // Target IDE Platform

    plugins {
        // Plugin Dependencies
    }
}
  1. In the build.gradle.kts file, the signPlugin and publishPlugin tasks can be configured using the with function to avoid repeating the set method for each property. Here's an example of how the signPlugin and publishPlugin tasks can be configured:
tasks {
    patchPluginXml {
        sinceBuild.set("222")
        untilBuild.set("232.*")
    }

    with(signPlugin) {
        certificateChain.set(System.getenv("CERTIFICATE_CHAIN"))
        privateKey.set(System.getenv("PRIVATE_KEY"))
        password.set(System.getenv("PRIVATE_KEY_PASSWORD"))
    }

    with(publishPlugin) {
        token.set(System.getenv("PUBLISH_TOKEN"))
    }
}
  1. In the gradle.properties file, the ARTIFACTORY_URL_SUFFIX property can be removed as it is not used in the code.

  2. In the plugin.xml file, the extensions element can be removed as it is empty and not used in the code.

  3. In the pluginIcon.svg file, the fill attribute of the <path> elements can be simplified by using a CSS class or inline styles. This can make the SVG code more readable and maintainable. Here's an example of how the fill attribute can be simplified:

<path class="fill-primary" d="..." />

or

<path style="fill: #F2C744;" d="..." />

By following these steps, the code can be simplified and made more concise.

Copy link
Collaborator

@ZacSweers ZacSweers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to add this functionality to the skate plugin, not as a separate plugin :)

@arpita184 arpita184 closed this Aug 9, 2023
@arpita184 arpita184 deleted the ap_linker_setup branch September 14, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants