Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using detached configurations for robolectric jar downloads #425

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

ZacSweers
Copy link
Collaborator

@ZacSweers ZacSweers commented Jun 28, 2023

Few benefits

  • It uses the same dependency resolution settings we have (i.e. artifactory repositories work out of the box)
  • Lets gradle to the heavy lifting with both downloading and caching downloads
  • Simpler setup for us with task up-to-date ness. Now we just always run the task but the most it every does is copy files. Extremely fast.

Resolves #423, resolves #422, resolves #424

Few benefits
- It uses the same dependency resolution settings we have (i.e. artifactory repositories work out of the box)
- Lets gradle to the heavy lifting
- Simpler setup for us with task up-to-date ness. Now we just always run the task but the most it every does is copy files. Extremely fast.
@ZacSweers ZacSweers requested a review from valeraz June 28, 2023 17:10
@ZacSweers ZacSweers enabled auto-merge June 28, 2023 17:11
@ZacSweers ZacSweers added this pull request to the merge queue Jun 29, 2023
Merged via the queue into main with commit f174372 Jun 29, 2023
2 checks passed
@ZacSweers ZacSweers deleted the z/robolectricWithConfigurations branch June 29, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants