Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow grpc metric collecting decorator to just the grpc services #1069

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

baroquebobcat
Copy link
Contributor

@baroquebobcat baroquebobcat commented Sep 11, 2024

Summary

Instead of adding the grpc.service metric decorator to all services declared with the builder, scope it to the grpc service.

When I was looking at the decorator usage a while ago, I noticed that the metric decorator was being added globally in a place that I wouldn't expect it to add a global decorator. This narrows that scope to just the grpc service being added.

Requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants