Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add next-gen future documentation #761

Merged
merged 8 commits into from
Nov 29, 2022

Conversation

WilliamBergamin
Copy link
Contributor

This PR aims to add documentation for

  • future concepts
    • manifest information
    • listening & responding to functions
  • future starting guide
  • migration guide
  • update the api-docs

I am seeking feedback on

  • the flow of the documentation
  • writing style (tried to keep it short and simple)
  • typos
  • links to api.dev.slack.com

NOTE everything in docs/api-docs/slack_bolt/ is generated code no need to review it

In order to run the documentation locally:

# clone project
git clone -b future-docs https://github.com/WilliamBergamin/bolt-python.git
cd bolt-python

# install python 3.9, this is optional
brew install pyenv
pyenv install 3.9.6

# create virtual env
pyenv local 3.9.6
python -m venv env_3.9.6
source env_3.9.6/bin/activate

#install ruby you will need rbenv you can install this with brew
rbenv install 2.7.1
rbenv global 2.7.1

# start webserver
gem install bundler jekyll
scripts/run_jekyll.sh

# should be available on http://127.0.0.1:4000/bolt-python/

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@WilliamBergamin WilliamBergamin added the docs Improvements or additions to documentation label Nov 9, 2022
@WilliamBergamin WilliamBergamin self-assigned this Nov 9, 2022
docs/_future/manifest.md Outdated Show resolved Hide resolved
@@ -1,3 +1,4 @@
source 'https://rubygems.org'
gem 'github-pages', group: :jekyll_plugins
gem 'dotenv'
gem 'webrick'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be required when new versions of ruby are running Jekyll

@@ -19,6 +19,7 @@ To learn more about opening configuration modals, [read the documentation](https

<div>
<span class="annotation">Refer to the module documents (<a href="https://slack.dev/bolt-python/api-docs/slack_bolt/kwargs_injection/args.html" target="_blank">common</a> / <a href="https://slack.dev/bolt-python/api-docs/slack_bolt/workflows/step/utilities/index.html" target="_blank">step-specific</a>) to learn the available arguments.</span>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My IDE was unable to parse the code block without this line

padding: 4px 10px;
border-radius: 12px;
margin-left: 10px;
}
.content .section-wrapper .highlighter-rouge {
grid-area: code;
}

pre {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes were made to fix a bug in the code block display

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #761 (2b8d053) into main (df35180) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #761   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files         173      173           
  Lines        5908     5908           
=======================================
  Hits         5437     5437           
  Misses        471      471           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bunch of minor tweaks and spelling things, but things are looking good!

docs/_future/getting_started_future.md Outdated Show resolved Hide resolved
docs/_future/listening_responding_functions.md Outdated Show resolved Hide resolved
docs/_future/listening_responding_functions.md Outdated Show resolved Hide resolved
docs/_future/listening_responding_functions.md Outdated Show resolved Hide resolved
docs/_future/listening_responding_functions.md Outdated Show resolved Hide resolved
docs/_future/listening_responding_functions.md Outdated Show resolved Hide resolved
@srajiang srajiang changed the title Doc: future-documentation Add next-gen documentation Nov 10, 2022
@srajiang srajiang changed the title Add next-gen documentation Add next-gen future documentation Nov 10, 2022
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Left some comments.

docs/_future/getting_started_future.md Outdated Show resolved Hide resolved
docs/_future/getting_started_future.md Outdated Show resolved Hide resolved
docs/_future/getting_started_future.md Outdated Show resolved Hide resolved
docs/_future/getting_started_future.md Outdated Show resolved Hide resolved
slack run
```

Executing `pip install -r requirements.txt` installs all the project requirements to your machine.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to link to any existing documentation we have around setting up a virtual env, as that is the recommended way of working in Python projects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I've been thinking about doing this in our documentation, currently this is how we do it in the rest of our docs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's chalk it up as a separate issue so we don't forget, and if/when we get to it we can update all the documentation (new platform or otherwise) to link to it where it makes sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created issue #777 to keep track of this

docs/_future/manifest.md Outdated Show resolved Hide resolved
docs/_future/manifest.md Outdated Show resolved Hide resolved
docs/_future/manifest_functions.md Outdated Show resolved Hide resolved
Copy link

@hello-ashleyintech hello-ashleyintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice nice! This is looking great 🎉 Left a few more small suggestions, please let me know if there are any questions!

docs/_future/concepts.md Show resolved Hide resolved
docs/_future/getting_started_future.md Outdated Show resolved Hide resolved
docs/_future/migrate_existing_app.md Outdated Show resolved Hide resolved
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left a few minor suggestions but nothing blocking.

slack run
```

Executing `pip install -r requirements.txt` installs all the project requirements to your machine.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's chalk it up as a separate issue so we don't forget, and if/when we get to it we can update all the documentation (new platform or otherwise) to link to it where it makes sense.

docs/_future/manifest_workflows.md Outdated Show resolved Hide resolved
@WilliamBergamin WilliamBergamin merged commit 929008e into slackapi:main Nov 29, 2022
@WilliamBergamin WilliamBergamin deleted the future-docs branch November 29, 2022 20:42
@sharvesh06
Copy link

sharvesh06 commented Mar 3, 2023

@WilliamBergamin @seratch Do you know when these next gen docs are gonna be available to the end users?

@WilliamBergamin
Copy link
Contributor Author

Hi @sharvesh06 thanks for asking these docs are available to users https://slack.dev/bolt-python/future/concepts

You must use the beta release of python to try this out, it end with dev 1.16.2 is the latest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants