dense_*: workaround for the max() ambiguity with MAX macro. #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skypjack
added
enhancement
|
Please, do not update the single include file. It's generated automatically by a script. The PR looks good otherwise. Thanks. 👍 |
There is ambiguity between std::max() and MAX macro, which propagates via "Windows.h", on the Windows platform. In order not to bother the user with the NOMINMAX definitions, the bracketing method was chosen.
pavelpokutnev
force-pushed
the
pavel/min-max-ambiguity
branch
from
46a4057
to
d665492
Compare
|
OK, just updated the PR. |
skypjack
pushed a commit
that referenced
this pull request
Aug 18, 2023
skypjack
pushed a commit
that referenced
this pull request
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is ambiguity between std::max() and MAX macro, which propagates via "Windows.h", on the Windows platform. In order not to bother the user with the NOMINMAX definitions, the bracketing method was chosen.