upgrade to github.com/hashicorp/terraform-plugin-sdk/v2 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnps
commented
May 18, 2023
| @@ -196,7 +196,7 @@ func resourceSiteRule() *schema.Resource { | |||
| }, | |||
| }, | |||
| "rate_limit": { | |||
| Type: schema.TypeMap, | |||
| Type: schema.TypeSet, | |||
There was a problem hiding this comment.
Fixes:
│ 1 error occurred:
│ * resource sigsci_site_rule: rate_limit: TypeMap with Elem *Resource not supported,use TypeList/TypeSet with Elem *Resource or
│ TypeMap with Elem *Schema
shawnps
commented
May 18, 2023
| @@ -214,7 +214,6 @@ func resourceSiteRule() *schema.Resource { | |||
| "duration": { | |||
| Type: schema.TypeInt, | |||
| Description: "duration in seconds (300 < x < 3600)", | |||
| Default: 600, | |||
There was a problem hiding this comment.
Fixes:
│ 1 error occurred:
│ * resource sigsci_site_rule: duration: Default cannot be set with Required
shawnps
commented
May 18, 2023
| @@ -149,7 +149,6 @@ func resourceCorpCloudWAFInstance() *schema.Resource { | |||
| Type: schema.TypeList, // use TypeList to workaround SDK TypeMap limitation with only string value support: https://github.com/hashicorp/terraform-plugin-sdk/issues/62 | |||
| Description: "The sites primary Agent key", | |||
| Computed: true, | |||
| MaxItems: 1, | |||
There was a problem hiding this comment.
Fixes:
│ 1 error occurred:
│ * resource sigsci_corp_cloudwaf_instance: deployment: MaxItems is for configurable attributes,there's nothing to
│ configure on computed-only field
shawnps
commented
May 18, 2023
| @@ -60,7 +60,7 @@ func resourceSite() *schema.Resource { | |||
| Optional: true, | |||
| }, | |||
| "primary_agent_key": { | |||
| Type: schema.TypeMap, | |||
| Type: schema.TypeSet, | |||
There was a problem hiding this comment.
Fixes:
│ 1 error occurred:
│ * resource sigsci_site: primary_agent_key: TypeMap with Elem *Resource not supported,use TypeList/TypeSet with Elem *Resource or
│ TypeMap with Elem *Schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.