Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to select all media in selection mode #5685

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

phraemer
Copy link

@phraemer phraemer commented Oct 16, 2023

First time contributor checklist

Contributor checklist

  • My commits are rebased on the latest main branch
  • My commits are in nice logical chunks
  • My contribution is fully baked and is ready to be merged as is
  • I have tested my contribution on these devices:
  • iPhone 13, iOS 17.0.3
  • Simulator iPhone 15, iOS 17.0

Description

When deleting media it can take an extraordinary amount of time to select all items to delete as there is currently no way to select all. This is not only inconvenient but impacts user security when it may be necessary to delete all media from a conversation quickly without losing the text of the conversation. It's also a very common UI pattern to be able to select all items.

This PR adds a text button to the task bar allowing the user in one tap to select all the items in the view. When any items are selected the text of the buttons allows the user to select none.
The button is placed on the left away from the Delete button to prevent any accidental presses.

Screen.Recording.2023-10-16.at.23.13.24.mov

@phraemer phraemer marked this pull request as ready for review October 17, 2023 06:38
Copy link

@pawisoon pawisoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my code clean-up suggestion :)
Approved 👍

@Excelbrains
Copy link

I hope that this welcome feature is added in short notice, since a lot of users are struggling with cleansing their media in Signal!

@iSack97
Copy link

iSack97 commented Jan 14, 2024

Please merge this asap, a lot of people needs this

@phraemer
Copy link
Author

phraemer commented Feb 6, 2024

Belated happy new year to the Signal team 😚🎉

How are we looking at getting this in?
It will help so many people!

@phraemer
Copy link
Author

@harry-signal please please please can we get this merged? It's so frustratingly difficult and time consuming to manage storage space in Signal on iOS and this will be such a huge help for such a small change.

@tohrxyz
Copy link

tohrxyz commented Mar 31, 2024

+1 hoping for this to come asap

@phraemer
Copy link
Author

phraemer commented Jun 6, 2024

I am absolutely begging you to get this in please!
It's utterly impractical to manually select items for what are now years of stuff in a chat.

@harry-signal ... anyone? Just let me know what I can do to move this simple but incredibly useful change forward.

Thanks.

@iSack97
Copy link

iSack97 commented Aug 9, 2024

I know devs are working on other backup functionality, but this is a fucking joke. They just need to push this and a lot of people would have easier lifes

@phraemer
Copy link
Author

Approaching a year now and no feedback. Doesn’t look like you have merged any contributions to iOS Signal for more than a year either. Some communication from anyone from Signal would be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants