Skip to content

Commit

Permalink
Merge pull request #90 from shystruk/dev
Browse files Browse the repository at this point in the history
Fix error messages spacing
  • Loading branch information
shystruk authored Dec 8, 2021
2 parents 636e66e + 87675b5 commit c0dfb04
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 12 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "csv-file-validator",
"version": "1.13.0",
"version": "1.13.1",
"description": "Validation of CSV file against user defined schema (returns back object with data and invalid messages)",
"main": "./src/csv-file-validator.js",
"types": "./src/csv-file-validator.d.ts",
Expand Down
17 changes: 6 additions & 11 deletions src/csv-file-validator.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,9 @@
if (valueConfig.name !== columnValue) {
file.inValidMessages.push(
_isFunction(valueConfig.headerError)
? valueConfig.headerError(
columnValue, valueConfig.name, rowIndex + 1, columnIndex + 1
)
: `Header name ${columnValue} is not correct or missing in the ${rowIndex + 1} row/
${columnIndex + 1} column. The Header name should be ${valueConfig.name}`
? valueConfig.headerError(columnValue, valueConfig.name, rowIndex + 1, columnIndex + 1)
: 'Header name ' + columnValue + ' is not correct or missing in the ' + (rowIndex + 1) + ' row / '
+ (columnIndex + 1) + ' column. The Header name should be ' + valueConfig.name
);
}

Expand All @@ -94,23 +92,20 @@
file.inValidMessages.push(
_isFunction(valueConfig.requiredError)
? valueConfig.requiredError(valueConfig.name, rowIndex + 1, columnIndex + 1)
: String(`${valueConfig.name} is required in the ${rowIndex + 1} row/
${columnIndex + 1} column`)
: String(valueConfig.name + ' is required in the ' + (rowIndex + 1) + ' row / ' + (columnIndex + 1) + ' column')
);
} else if (valueConfig.validate && !valueConfig.validate(columnValue)) {
file.inValidMessages.push(
_isFunction(valueConfig.validateError)
? valueConfig.validateError(valueConfig.name, rowIndex + 1, columnIndex + 1)
: String(`${valueConfig.name} is not valid in the ${rowIndex + 1} row/
${columnIndex + 1} column`)
: String(valueConfig.name + ' is not valid in the ' + (rowIndex + 1) + ' row / ' + (columnIndex + 1) + ' column')
);
} else if (valueConfig.dependentValidate &&
!valueConfig.dependentValidate(columnValue, _getClearRow(row))) {
file.inValidMessages.push(
_isFunction(valueConfig.validateError)
? valueConfig.validateError(valueConfig.name, rowIndex + 1, columnIndex + 1)
: String(`${valueConfig.name} not passed dependent validation in the ${rowIndex + 1} row/
${columnIndex + 1} column`)
: String(valueConfig.name + ' not passed dependent validation in the ' + (rowIndex + 1) + ' row / ' + (columnIndex + 1) + ' column')
);
}

Expand Down

0 comments on commit c0dfb04

Please sign in to comment.