Upgrade django version #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've fixed the admin file to filter using the actual default manager, rather than rely on the conventional "objects".
Pull to get auto-hiding site filters on the change list pages. Thanks Robert!
as the current object being edited.
Conflicts: multisite/admin.py
This makes django.contrib.sites.tests pass.
This is so that you can have multiple SiteIDHooks, if you so desire. The singleton should be enforced by settings.py, not by a module-level global.
…ook.
In addition, remove the need to know about threadlocals:
>>> from multisite import SiteID
…'s cache. This replaces middleware.HOST_CACHE which was a module-level dictionary. These are undesirable because they're not shared between processes and because they cannot be expired properly.
….SITE_ID settings.SITE_ID must now resemble multisite.SiteID.
… view. When request.get_host() does not resolve to a known Site, django-multisite will now respond with an HTTP 404 Not Found. If settings.MULTISITE_FALLBACK is defined, django-multisite will call that view to decide how to continue.
Includes South migrations, for those using South.
Will be used to test output from management commands
Remove deprecated NoArgsCommand from update_public_suffix_list management command Adds tests for the management command also.
…ote_model for further clarity
rel.to removed in Django 2.0
It's incompatible with the versions of django that we now support
Undocumented, and broken since Django 1.6, which is no loger supported
Support django2.0
With multiple processes, we can run into a race condition where the site cache is invalidated while another process attempts to access it. This patches _get_site_by_id to retrieve the site from the database if it isn't found by when _get_site_by_id returns
Avoid the race condition by fetching the site from the cache at the beginning of _get_site_by_id.
Fix KeyError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django 2.2 will be released on April 2019, so the last version is set to 2.2.