[Regression fix] local DNS uses mode tcp_and_udp by default
#1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I've noticed in the CI that there's only "build with all features", but no "test with all features". Had the tests been run with all features enabled, this regression would have been caught in the commit that introduced this regression (8d3461b). So maybe this is something you would want to enable, but I'll leave that decision up to the maintainers. |
- local DNS uses mode `tcp_and_udp` by default
|
Out of curiosity, what is causing rustfmt to format the code differently on our machines? I thought having a |
|
Because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tcp_onlymode, causing UDP-only clients to fail #1281