chore(deps): bump smoltcp from 0.9.1 to 0.10.0 #449
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
15 warnings
this `if` statement can be collapsed:
crates/shadowsocks/src/plugin/mod.rs#L230
warning: this `if` statement can be collapsed
--> crates/shadowsocks/src/plugin/mod.rs:230:9
|
230 | / if !terminated {
231 | | if self.process.start_kill().is_ok() {
232 | | debug!("killed plugin process {:?}", self.process.id());
233 | | }
234 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
230 ~ if !terminated && self.process.start_kill().is_ok() {
231 + debug!("killed plugin process {:?}", self.process.id());
232 + }
|
|
very complex type used. Consider factoring parts into `type` definitions:
crates/shadowsocks/src/relay/udprelay/proxy_socket.rs#L519
warning: very complex type used. Consider factoring parts into `type` definitions
--> crates/shadowsocks/src/relay/udprelay/proxy_socket.rs:519:10
|
519 | ) -> Poll<ProxySocketResult<(usize, Address, usize, Option<UdpSocketControlData>)>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
very complex type used. Consider factoring parts into `type` definitions:
crates/shadowsocks/src/relay/udprelay/proxy_socket.rs#L543
warning: very complex type used. Consider factoring parts into `type` definitions
--> crates/shadowsocks/src/relay/udprelay/proxy_socket.rs:543:10
|
543 | ) -> Poll<ProxySocketResult<(usize, SocketAddr, Address, usize, Option<UdpSocketControlData>)>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
unnecessary hashes around raw string literal:
crates/shadowsocks-service/src/acl/mod.rs#L195
warning: unnecessary hashes around raw string literal
--> crates/shadowsocks-service/src/acl/mod.rs:195:17
|
195 | r#"^(?:(?:\((?:\?:)?\^\|\\\.\)|(?:\^\.(?:\+|\*))?\\\.)((?:[\w-]+(?:\\\.)?)+)|\^((?:[\w-]+(?:\\\.)?)+))\$$"#,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `r"^(?:(?:\((?:\?:)?\^\|\\\.\)|(?:\^\.(?:\+|\*))?\\\.)((?:[\w-]+(?:\\\.)?)+)|\^((?:[\w-]+(?:\\\.)?)+))\$$"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
= note: `#[warn(clippy::needless_raw_string_hashes)]` on by default
|
module has the same name as its containing module:
crates/shadowsocks-service/src/local/socks/server/mod.rs#L15
warning: module has the same name as its containing module
--> crates/shadowsocks-service/src/local/socks/server/mod.rs:15:1
|
15 | mod server;
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
|
the borrowed expression implements the required traits:
crates/shadowsocks-service/src/manager/server.rs#L377
warning: the borrowed expression implements the required traits
--> crates/shadowsocks-service/src/manager/server.rs:377:33
|
377 | let _ = fs::remove_file(&server_config_path);
| ^^^^^^^^^^^^^^^^^^^ help: change this to: `server_config_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
this OR pattern can be rewritten using a range:
src/logging/mod.rs#L58
warning: this OR pattern can be rewritten using a range
--> src/logging/mod.rs:58:9
|
58 | 0 | 1 | 2 | 3 => logging_builder
| ^^^^^^^^^^^^^ help: try: `0..=3`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_patterns
= note: `#[warn(clippy::manual_range_patterns)]` on by default
|
useless conversion to the same type: `u32`:
src/sys.rs#L124
warning: useless conversion to the same type: `u32`
--> src/sys.rs:124:42
|
124 | if libc::initgroups(pwd.pw_name, pwd.pw_gid.try_into().unwrap()) != 0 {
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: consider removing `.try_into()`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
this `if` statement can be collapsed:
crates/shadowsocks/src/plugin/mod.rs#L230
warning: this `if` statement can be collapsed
--> crates/shadowsocks/src/plugin/mod.rs:230:9
|
230 | / if !terminated {
231 | | if self.process.start_kill().is_ok() {
232 | | debug!("killed plugin process {:?}", self.process.id());
233 | | }
234 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
230 ~ if !terminated && self.process.start_kill().is_ok() {
231 + debug!("killed plugin process {:?}", self.process.id());
232 + }
|
|
very complex type used. Consider factoring parts into `type` definitions:
crates/shadowsocks/src/relay/udprelay/proxy_socket.rs#L519
warning: very complex type used. Consider factoring parts into `type` definitions
--> crates/shadowsocks/src/relay/udprelay/proxy_socket.rs:519:10
|
519 | ) -> Poll<ProxySocketResult<(usize, Address, usize, Option<UdpSocketControlData>)>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
very complex type used. Consider factoring parts into `type` definitions:
crates/shadowsocks/src/relay/udprelay/proxy_socket.rs#L543
warning: very complex type used. Consider factoring parts into `type` definitions
--> crates/shadowsocks/src/relay/udprelay/proxy_socket.rs:543:10
|
543 | ) -> Poll<ProxySocketResult<(usize, SocketAddr, Address, usize, Option<UdpSocketControlData>)>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
unnecessary hashes around raw string literal:
crates/shadowsocks-service/src/acl/mod.rs#L195
warning: unnecessary hashes around raw string literal
--> crates/shadowsocks-service/src/acl/mod.rs:195:17
|
195 | r#"^(?:(?:\((?:\?:)?\^\|\\\.\)|(?:\^\.(?:\+|\*))?\\\.)((?:[\w-]+(?:\\\.)?)+)|\^((?:[\w-]+(?:\\\.)?)+))\$$"#,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `r"^(?:(?:\((?:\?:)?\^\|\\\.\)|(?:\^\.(?:\+|\*))?\\\.)((?:[\w-]+(?:\\\.)?)+)|\^((?:[\w-]+(?:\\\.)?)+))\$$"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
= note: `#[warn(clippy::needless_raw_string_hashes)]` on by default
|
module has the same name as its containing module:
crates/shadowsocks-service/src/local/socks/server/mod.rs#L15
warning: module has the same name as its containing module
--> crates/shadowsocks-service/src/local/socks/server/mod.rs:15:1
|
15 | mod server;
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
|
the borrowed expression implements the required traits:
crates/shadowsocks-service/src/manager/server.rs#L377
warning: the borrowed expression implements the required traits
--> crates/shadowsocks-service/src/manager/server.rs:377:33
|
377 | let _ = fs::remove_file(&server_config_path);
| ^^^^^^^^^^^^^^^^^^^ help: change this to: `server_config_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
this OR pattern can be rewritten using a range:
src/logging/mod.rs#L58
warning: this OR pattern can be rewritten using a range
--> src/logging/mod.rs:58:9
|
58 | 0 | 1 | 2 | 3 => logging_builder
| ^^^^^^^^^^^^^ help: try: `0..=3`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_patterns
= note: `#[warn(clippy::manual_range_patterns)]` on by default
|