Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add searched videos to the queue #119

Merged
merged 12 commits into from
Mar 29, 2024

Conversation

sgobotta
Copy link
Owner


name: Pull Request
about:
title: 'Add videos from search'
labels: ''
assignees: '@sgobotta'

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This PR provides:

  • Styles improvement
  • Add videos from the search list

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

Checklist

The following options in bold are required for a PR approval. Please check the boxes only if necessary, it help us minimizing the reviewing process.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@coveralls
Copy link

coveralls commented Jan 29, 2024

Pull Request Test Coverage Report for Build 9948d6c1be92ba8612a3ac9d59ca39df1876ca30-PR-119

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 177 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.1%) to 48.962%

Files with Coverage Reduction New Missed Lines %
//lib/livedj_web/live/components/player_controls/fullscreen_control_component.ex 3 0.0%
//lib/livedj_web/components/custom_components.ex 11 41.67%
//lib/livedj_web/live/components/player_controls/volume_control_component.ex 14 0.0%
//lib/livedj_web/components/list_component.ex 17 0.0%
//lib/livedj_web/live/sessions/room_live/form_component.ex 17 0.0%
//lib/livedj_web/components/core_components.ex 18 82.98%
//lib/livedj_web/live/components/search_bar_component.ex 18 0.0%
//lib/livedj/sessions.ex 79 9.26%
Totals Coverage Status
Change from base Build e2ab3a482eb958091e8f79352d479de07601f45e: -0.1%
Covered Lines: 637
Relevant Lines: 1301

💛 - Coveralls

@sgobotta sgobotta merged commit 1b96def into dev Mar 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants