Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/play videos on list item click #116

Merged
merged 10 commits into from
Jan 10, 2024

Conversation

sgobotta
Copy link
Owner


name: Pull Request
about: Let us know about your contribution
title: 'Play video by clicking a button in the playlist'
labels: ''
assignees: '@sgobotta'

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This PR provides:

  • Add client player support to react to the current player state
  • Minor UI updates to the playlist
  • Scroll to current item on previous/next track click
  • Margin updates in the playlist
  • Add a channel attribute to the video model
  • Add missing translations
  • Add skeleton loaders in the player controls live
  • Add missing translations and fix tests
  • Play track on item list click

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

Checklist

The following options in bold are required for a PR approval. Please check the boxes only if necessary, it help us minimizing the reviewing process.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

Pull Request Test Coverage Report for Build 8e56c5c0a058a89b96152f4365935c5346944979-PR-116

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.8%) to 51.789%

Totals Coverage Status
Change from base Build 20588b72b07c3b5c2ee650f58238d6342e376682: -1.8%
Covered Lines: 637
Relevant Lines: 1230

💛 - Coveralls

@sgobotta sgobotta merged commit eecd030 into dev Jan 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant