Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #844 by returning Ok(()) if the port, username or password is empty #845

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chanced
Copy link

@chanced chanced commented Jul 2, 2023

resolves #844 by checking for a value before returning Err(()) in set_port, set_username and set_password.

@chanced chanced marked this pull request as draft July 3, 2023 13:33
@chanced
Copy link
Author

chanced commented Jul 3, 2023

This pull request is lacking in tests at the moment. I'll add them if ya'll are interested in it.

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.05% ⚠️

Comparison is base (0e25146) 82.44% compared to head (b4ff992) 82.39%.
Report is 22 commits behind head on master.

❗ Current head b4ff992 differs from pull request most recent head 941dade. Consider uploading reports for the commit 941dade to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
- Coverage   82.44%   82.39%   -0.05%     
==========================================
  Files          20       20              
  Lines        3343     3352       +9     
==========================================
+ Hits         2756     2762       +6     
- Misses        587      590       +3     
Files Changed Coverage Δ
url/src/lib.rs 75.83% <50.00%> (-0.24%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chanced chanced changed the title Resolves #844 by returning Ok(()) if username or password is empty Resolves #844 by returning Ok(()) if the port, username or password is empty Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set_port, set_username & set_password should check for a value before returning Err(())
1 participant