Allow generation of custom values for hash and range key #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robhughadams
force-pushed
the
master
branch
3 times, most recently
from
cb20a3a
to
28fd9d1
Compare
robhughadams
commented
Jun 22, 2023
| @@ -1915,7 +1915,7 @@ describe('#validateServiceProxies()', () => { | |||
| expect(() => serverlessApigatewayServiceProxy.validateServiceProxies()).to.not.throw() | |||
| }) | |||
|
|
|||
| it('should not throw error if the "hashKey" is object and has both "pathParam" and "attributeType" properties', () => { | |||
| it('should not throw error if the "hashKey" is object and has both "keyName" and "attributeType" properties', () => { | |||
There was a problem hiding this comment.
There's already a it('should not throw error if the "hashKey" is object and has both "pathParam" and "attributeType" properties', () => { on line 1876 so I repurposed this test.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should resolve #201