Update db_instance_class to db_instance_type #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only changed the variable declaration. Where it's used should be updated as well |
enekui
reviewed
Nov 21, 2023
There was a problem hiding this comment.
Same as with other variables, this naming keeps aligned with the real parameter of the official AWS module and the AWS API.
instance_type should be only used when referring to EC2.
I would strongly suggest to keep it as it is.
https://registry.terraform.io/modules/terraform-aws-modules/rds/aws/latest?tab=inputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nicer to rename
db_instance_classtodb_instance_typeconsistency with other variables