-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include DRAGEN metrics in MULTIQC report #2
base: dev
Are you sure you want to change the base?
Conversation
As a part of this, remove stub run from multiqc to check whether stub run for dragen, which generates a test file recognised by multiqc works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Thanks @RHReynolds ! 😍
Maybe we can use -stub
to run the tests given we can't really test DRAGEN via native Github Actions machines. Hopefully, that will give us something to test though for CI/CD.
That sounds like a good idea. Do you know of a way to run I ended up removing the We could do the same for other nf-core modules, and just introduce a Happy to implement whichever strategy in this PR, or a new PR, if that's more appropriate. |
Major changes include:
.csv
outputs from DRAGEN, which can be used as inputs for the MULTIQC module.dragen.nf
module to test the logic of the workflow and to ensure DRAGEN metrics are captured by MULTIQCMinor changes include:
arm
profile for docker (testing on a mac, sorry!)${meta.id}/
to thepublishDir
for the DRAGEN modules, so that DRAGEN outputs are stored in separate folders for each samplePR checklist
nextflow run . -profile test,docker
).CHANGELOG.md
is updated.