Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if fusion is enabled via the Platform API #57

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

drpatelh
Copy link
Member

Alternative implementation to #56

@@ -49,8 +50,10 @@ Map getRunMetadata(meta, log, api_endpoint, trustStorePath, trustStorePassword)
def workflowResponse = client.get(path: "/workflow/${runId}", query: ["workspaceId":workspaceId], headers: authHeader)
if (workflowResponse.statusCode == 200) {
def metaMap = workflowResponse?.json?.workflow?.subMap("runName", "workDir", "projectName")
def config = new ConfigSlurper().parse( workflowResponse?.json?.workflow?.configText )
Copy link
Member Author

@drpatelh drpatelh Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line fails to load in the config just for viralrecon but works for other pipelines.

A quick way to reproduce would be to download the raw functions.nf and append the lines below at the end of the file. This would assume you have access to the workspaces below via exporting TOWER_ACCESS_TOKEN for Seqera Cloud.

def meta = [id:'LanYfJk1vaHuD', workspace:'scidev/azure']         // WORKS: no fusion   / nf-core/rnaseq
// def meta = [id:'3Z627eCb3HqUy3', workspace:'seqeralabs/showcase'] // WORKS: with fusion / nf-core/rnaseq
// def meta = [id:'13gHs3OF4AYPI5', workspace:'scidev/azure']        // FAILS: no fusion   / nf-core/viralrecon
def api_endpoint = 'https://api.cloud.seqera.io/'
def java_truststore_path = ''
def java_truststore_password = ''
metaOut = getRunMetadata(meta, log, api_endpoint, java_truststore_path, java_truststore_password)
println(metaOut)

You can then run the file directly as a Nextflow script to test:

nextflow run functions.nf

The fix in this PR is much more fragile because we are unable to load the config into a map and then checking whether Fusion is enabled. Instead, we are using a regex to check whether fusion is enabled via a pattern match in the config string.

This isn't a great solution but we can't think of anything more robust right now and can make improvements in the future.

@drpatelh
Copy link
Member Author

Will merge this in for now to get a release out. We can patch with a better solution later as mentioned in #55

@drpatelh drpatelh merged commit a98423a into dev Jul 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants