Seqera containers: POC 5 #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxulysse
reviewed
Jun 18, 2024
Comment on lines
+12
to
+15
| docker_arm64 { process.withName: 'PLOT_RUN_GANTT' { container = 'community.wave.seqera.io/library/click_pandas_plotly_express_typing:2e5e17c7ed2d1115' } } | ||
| singularity { process.withName: 'PLOT_RUN_GANTT' { container = 'oras://community.wave.seqera.io/library/click_pandas_plotly_express_typing:a4af841350996386' } } | ||
| singularity_arm64 { process.withName: 'PLOT_RUN_GANTT' { container = 'oras://community.wave.seqera.io/library/click_pandas_plotly_express_typing:3fe674b9fa7b15b8' } } |
There was a problem hiding this comment.
We don't need withName selectors
There was a problem hiding this comment.
This file is being loaded by the top level pipeline, as part of the regular pipeline config. So I think we do?
There was a problem hiding this comment.
yeah, that's why I asked for module config, otherwise this is almost the same as proposal 4
bentsherman
reviewed
Jun 18, 2024
Comment on lines
+6
to
+11
| includeConfig '../../modules/local/seqera_runs_dump/nextflow.config' | ||
| include { PLOT_RUN_GANTT } from '../../modules/local/plot_run_gantt' | ||
| includeConfig '../../modules/local/plot_run_gantt/nextflow.config' | ||
| include { MULTIQC } from '../../modules/nf-core/multiqc' | ||
| includeConfig '../../modules/nf-core/multiqc/nextflow.config' | ||
|
|
There was a problem hiding this comment.
Are you proposing this new syntax? It is not currently supported
|
Closing as I invented some Nextflow syntax. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #46 except the
includeConfigis alongside theinclude, to make automation easier and also make it easier to trace config logic.👉🏻 See 2499af7 for only differences to #46
@bentsherman / others - will loading the config in the main script instead of
nextflow.configlike this break stuff / do weird things? I feel like it's bad practice, even if the code is easier to read.