Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update semantic-release monorepo (major) #332

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 1, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@semantic-release/commit-analyzer ^12.0.0 -> ^13.0.0 age adoption passing confidence
@semantic-release/release-notes-generator ^13.0.0 -> ^14.0.0 age adoption passing confidence
semantic-release 23.1.1 -> 24.0.0 age adoption passing confidence

Release Notes

semantic-release/commit-analyzer (@​semantic-release/commit-analyzer)

v13.0.0

Compare Source

Bug Fixes
  • log the raw message again (e2f5d6c)
Features
  • support latest conventional-changelog packages (0254d7a)
BREAKING CHANGES
  • by supporting the latest major versions of conventional-changelog packages, we are
    dropping support for previous major versions of those packages due to the breaking changes between
    majors. this only impacts your project if you are installing alongside semantic-release, so updating
    those packages to latest version should be the only change you need for this update. no action
    should be necessary if you are using default semantic-release config
semantic-release/release-notes-generator (@​semantic-release/release-notes-generator)

v14.0.0

Compare Source

Features
BREAKING CHANGES
  • by supporting the latest major versions of conventional-changelog packages, we are dropping support for previous major versions of those packages due to the breaking changes between majors. this only impacts your project if you are installing alongside semantic-release, so updating those packages to latest version should be the only change you need for this update. no action should be necessary if you are using default semantic-release config
semantic-release/semantic-release (semantic-release)

v24.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/major-semantic-release-monorepo branch 3 times, most recently from 36f4919 to 6415a8e Compare June 5, 2024 12:36
@travi
Copy link
Member

travi commented Jun 7, 2024

this should be considered a breaking change and have the supported peerDependency range bumped.

as an alternative, i wonder if it makes more sense to just make semantic-release a direct dependency and drop the direct dependencies on the commit-analyzer and release-notes-generator plugins

@renovate renovate bot force-pushed the renovate/major-semantic-release-monorepo branch from 6415a8e to 93c6223 Compare June 10, 2024 03:45
@fgreinacher
Copy link
Contributor

fgreinacher commented Jun 11, 2024

this should be considered a breaking change and have the supported peerDependency range bumped.

as an alternative, i wonder if it makes more sense to just make semantic-release a direct dependency and drop the direct dependencies on the commit-analyzer and release-notes-generator plugins

Yes, this sounds like a good idea. I'll prepare a PR! Just looked at this again. All other plugins are using semantic-release as peer dependency. I think we should keep this consistent to keep things easier to maintain.

@fgreinacher fgreinacher force-pushed the renovate/major-semantic-release-monorepo branch 2 times, most recently from 9214907 to 9b027d5 Compare June 11, 2024 07:09
@renovate renovate bot force-pushed the renovate/major-semantic-release-monorepo branch from 9b027d5 to 9431c57 Compare June 11, 2024 07:10
The new semantic-release version adds support for the latest conventional-changelog
packages

BREAKING CHANGE: by supporting the latest major versions of conventional-changelog
packages, we are dropping support for previous major versions of those
packages due to the breaking changes between majors. this only impacts
your project if you are installing alongside semantic-release, so updating
those packages to latest version should be the only change you need for
this update. no action should be necessary if you are using default
semantic-release config
Copy link
Contributor Author

renovate bot commented Jun 11, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@fgreinacher
Copy link
Contributor

fgreinacher commented Jun 11, 2024

I have pushed eb8fcf1 to bump the peer dependency and included a breaking change trailer.

@fgreinacher fgreinacher requested a review from travi June 11, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants