Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds French translation #186

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adds French translation #186

wants to merge 2 commits into from

Conversation

Te-k
Copy link

@Te-k Te-k commented Aug 19, 2024

Hi,

Here is a translation in French of the app strings.

I see that there is also a list of pages in English and German here https://tpe.seemoo.tu-darmstadt.de/articles/airguard_articles_en.json, is there a way to submit a PR to translate these pages too? Or should I send an email?

I am happy to maintain the French translation in collaboration with the Echap non profit in France as we are going to recommend using it in our guide and would love to have it maintained in French. Drop me an email at tek AT randhome.io if a new version requires translation, I am happy to continue doing that.

@Te-k
Copy link
Author

Te-k commented Aug 20, 2024

I have added some unicode to use the right typo in French, I have used \u02bc as it seems to be the right way to do but it likely need some testing

@Sn0wfreezeDev
Copy link
Member

Thanks for adding French as a language. We will check if this is all rendered well and then accept your pull request.

@Te-k
Copy link
Author

Te-k commented Aug 21, 2024

Thanks @Sn0wfreezeDev . Would that be okay if I also translated the markdown pages at https://tpe.seemoo.tu-darmstadt.de/articles/airguard_articles_en.json ?

@Sn0wfreezeDev
Copy link
Member

Sure, please go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants