Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print prestop logs to pod logs and extend readme with configmap approach #1

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Print prestop logs to pod logs and extend readme with configmap approach #1

merged 5 commits into from
Sep 19, 2024

Conversation

PidgeyBE
Copy link
Contributor

Small change to print the prestop logs also in the pod logs

@PidgeyBE PidgeyBE changed the title Print prestop logs to pod logs Print prestop logs to pod logs and extend readme with configmap approach Sep 18, 2024
@PidgeyBE PidgeyBE mentioned this pull request Sep 18, 2024
Open
colinodell
colinodell approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@colinodell colinodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the contribution!

If you don't mind, I've got a couple of minor tweaks I'd like to add to this before merging. I'll push those up shortly.

README.md Show resolved Hide resolved
buildkit-prestop.sh Outdated Show resolved Hide resolved
@colinodell colinodell merged commit 8bce54f into seatgeek:main Sep 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinodell colinodell colinodell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PidgeyBE @colinodell