Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loop: add Sentinel iterator support to parallel_for_each() #2475

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tchaikov
Copy link
Contributor

@tchaikov tchaikov commented Oct 5, 2024

before this change, we only support containers, whose begin() and end() are of the same type, but ranges do not have this requirement.

in order to support range views, let's relax this requirement. so that, we can pass two iterators denoting a range to parallel_for_each(). see also b1b0bff.

@tchaikov tchaikov force-pushed the loop-range branch 7 times, most recently from 79f47ed to bc29141 Compare October 5, 2024 14:42
before this change, we only support containers, whose `begin()` and
`end()` are of the same type, but ranges do not have this requirement.

in order to support range views, let's relax this requirement. so that,
we can pass two iterators denoting a range to `parallel_for_each()`.
see also b1b0bff.

Signed-off-by: Kefu Chai <[email protected]>
@tchaikov tchaikov changed the title loop: add range support to parallel_for_each() loop: add Sentinel iterator support to parallel_for_each() Oct 6, 2024
Copy link
Contributor

@dawmd dawmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants