build: do not support c-ares >= 1.33 #2473
Merged
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we don't support c-ares >= 1.33 yet. so error out when c-ares >= 1.33 is detected. Refs scylladb#2472 Signed-off-by: Kefu Chai <[email protected]>
tchaikov
force-pushed
the
incompatible-with-c-ares-1.33
branch
from
9d4efcc
to
a8850ac
Compare
|
@elcallio hi Calle, could you help review this change? |
|
Looks ok to me, but I thought we still built c-ares as a submodule to seastar, based on our fork? |
|
hi Calle, thank you for your review. the c-ares submodule was dropped in 8d99e3c . |
|
@scylladb/seastar-maint hello maintainers, could you help merge this change? |
|
What's wrong with c-ares 1.33? |
|
@avikivity please see #2472 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we don't support c-ares 1.33 yet. so error out when c-ares >= 1.33 is detected.
Refs #2472