http: Add non-owning make_request to http client
#2468
Merged
+57
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xemul
reviewed
Oct 4, 2024
xemul
reviewed
Oct 4, 2024
kreuzerkrieg
force-pushed
the
EWZ/add-make_request-overloads
branch
from
d07bf90
to
048cb36
Compare
xemul
reviewed
Oct 7, 2024
To satisfy scylla's s3 client with future retry implementation add non-owning `make_request` to http client which is similar to the existing `make_request` but it doesn't take ownership of `request` and `reply_handler`
kreuzerkrieg
force-pushed
the
EWZ/add-make_request-overloads
branch
from
048cb36
to
d4c11f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To satisfy scylla's s3 client with future retry implementation add non-owning
make_requestto http client which is similar to the existingmake_requestbut it doesn't take ownership ofrequestandreply_handlerfixes: #2467