Don't rely on ring replication strategy in repair #4024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michal-Leszczynski
force-pushed
the
ml/fix-4022
branch
3 times, most recently
from
0416079
to
1f10cd1
Compare
|
@karol-kokoszka This PR is ready for review! |
Replication strategy is not returned from Scylla API, but assumed by SM. That's why we shouldn't rely on it. Fixes #4022
Michal-Leszczynski
force-pushed
the
ml/fix-4022
branch
from
1f10cd1
to
ebf9c20
Compare
|
@karol-kokoszka I added requested explanations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on #4034.
Fixes #4022