get_relocatable_s3_url: support :debug suffix in s3_version

[bhalevy]

Following up on 7721ac7 the :debug suffix may end up in s3_version
when passed to get_relocatable_s3_url.

[fruch]

nit:

Suggested change

	if s3_version.endswith(":debug"):
	s3_version = s3_version[:-6]
	debug_tag = ':debug'
	if s3_version.endswith(debug_tag):
	s3_version = s3_version[:-len(debug_tag)]

also python 3.9 and up, has: https://docs.python.org/3.9/library/stdtypes.html?highlight=removeprefix#str.removesuffix
but we'll need first deprecate 3.8 in ccm, python-driver still support 3.8, so it would need ccm to support it as well.

[bhalevy]

• applied suggestion from @fruch: get_relocatable_s3_url: support :debug suffix in s3_version #608 (comment)

[cezarmoise]

If get_relocatable_s3_url called from somewhere else other that the setup function? Another repo?
I don't understand how the :debug suffix gets there.

[bhalevy]

If get_relocatable_s3_url called from somewhere else other that the setup function? Another repo? I don't understand how the :debug suffix gets there.

(dtest-3.12.3) bhalevy@lt scylla-dtest$ pytest --scylla-version=unstable/master:latest:debug --tablets materialized_views_test.py::TestMaterializedViews::test_mv_resurrected_rows_after_decommission_interrupt
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/home/bhalevy/.pyenv/versions/3.12.3/envs/dtest-3.12.3/lib/python3.12/site-packages/_pytest/main.py", line 268, in wrap_session
INTERNALERROR>     config.hook.pytest_sessionstart(session=session)
INTERNALERROR>   File "/home/bhalevy/.pyenv/versions/3.12.3/envs/dtest-3.12.3/lib/python3.12/site-packages/pluggy/_hooks.py", line 513, in __call__
INTERNALERROR>     return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
INTERNALERROR>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/home/bhalevy/.pyenv/versions/3.12.3/envs/dtest-3.12.3/lib/python3.12/site-packages/pluggy/_manager.py", line 120, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/home/bhalevy/.pyenv/versions/3.12.3/envs/dtest-3.12.3/lib/python3.12/site-packages/pluggy/_callers.py", line 182, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>            ^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/home/bhalevy/.pyenv/versions/3.12.3/envs/dtest-3.12.3/lib/python3.12/site-packages/pluggy/_result.py", line 100, in get_result
INTERNALERROR>     raise exc.with_traceback(exc.__traceback__)
INTERNALERROR>   File "/home/bhalevy/.pyenv/versions/3.12.3/envs/dtest-3.12.3/lib/python3.12/site-packages/pluggy/_callers.py", line 103, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>           ^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/home/bhalevy/dev/scylla-dtest/conftest.py", line 359, in pytest_sessionstart
INTERNALERROR>     _scylla_mode = scylla_mode(cassandra_dir, scylla_version)
INTERNALERROR>                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/home/bhalevy/dev/scylla-dtest/tools/marks.py", line 57, in scylla_mode
INTERNALERROR>     return dtest_config.get_scylla_mode()
INTERNALERROR>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/home/bhalevy/dev/scylla-dtest/dtest_config.py", line 90, in get_scylla_mode
INTERNALERROR>     ccm_repo_cache_dir, _ = ccmlib.scylla_repository.setup(self.scylla_version)
INTERNALERROR>                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/home/bhalevy/.pyenv/versions/3.12.3/envs/dtest-3.12.3/lib/python3.12/site-packages/ccmlib/scylla_repository.py", line 276, in setup
INTERNALERROR>     s3_url = get_relocatable_s3_url(branch, s3_version, RELOCATABLE_URLS_BASE)
INTERNALERROR>              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/home/bhalevy/.pyenv/versions/3.12.3/envs/dtest-3.12.3/lib/python3.12/site-packages/ccmlib/scylla_repository.py", line 186, in get_relocatable_s3_url
INTERNALERROR>     raise CCMError(f"s3 url was not found for {branch}:{s3_version}")
INTERNALERROR> ccmlib.common.CCMError: s3 url was not found for master:latest:debug

[fruch]

@bhalevy

which branch of ccm you faced this ? @cezarmoise has a point.

I think you might be using old installed version inside your env

try installing ccm like:

pip install ../scylla-ccm -e

[bhalevy]

@bhalevy

which branch of ccm you faced this ? @cezarmoise has a point.

I think you might be using old installed version inside your env

try installing ccm like:

pip install ../scylla-ccm -e

Hmm, maybe I made a pilot error.
I now fail to reproduce this with 7721ac7.
So closing the PR. Sorry about the noise