cluster: add add_seed method #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be used after replacing nodes. We cannot add the replacing nodes as seeds right away since it's considered invalid to add a replacing node as a seed (probably for historical reasons). So we need to add it only after it's finished replace bootstrapping. Signed-off-by: Benny Halevy <[email protected]>
|
ping @fruch please review/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be used after replacing nodes.
We cannot add the replacing nodes to seeds right away since it's considered invalid to add a replacing node as a seed (probably for historical reasons).
So we need to add it only after it's finished
replace bootstrapping.