ccmlib: Remove usages of distutils #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0machi
force-pushed
the
remove-distutils
branch
5 times, most recently
from
12f6590
to
dd6ea47
Compare
fruch
reviewed
Dec 19, 2023
ccmlib/repository.py
Outdated
| @@ -385,15 +386,15 @@ def get_tagged_version_numbers(series='stable'): | |||
| for ref in (i.get('ref', '') for i in json.loads(tag_url.read())): | |||
| m = tag_regex.match(ref) | |||
| if m: | |||
| releases.append(LooseVersion(m.groups()[0])) | |||
| releases.append(Version(m.groups()[0])) | |||
There was a problem hiding this comment.
lets try using parse_version ? instead to supporting old LooseVersion
There was a problem hiding this comment.
Usng parse_version (or packaging.version) seems to be incompatible with tests we're running which check 2.6-dev-0.20211108.5f1e01cbb34-SNAPSHOT-5f1e01cbb34 (packaging.version.Version raises an exception there) as a parseable version, so I don't know if we can quite fit the version parsing as it is in parse_version.
fruch
reviewed
Dec 19, 2023
fruch
requested changes
Dec 19, 2023
k0machi
force-pushed
the
remove-distutils
branch
from
dd6ea47
to
de7e839
Compare
fruch
force-pushed
the
remove-distutils
branch
from
c296323
to
5ef0c8d
Compare
This change removes all uses of distutils modules and replaces them with either direct replacements or extractions from the library. LooseVersion is extracted into ccmlib.utils.version and dir_util.copy_tree is replaced by shutil.copytree. Fixes scylladb#537
fruch
force-pushed
the
remove-distutils
branch
from
5ef0c8d
to
3bbcbcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes all uses of distutils modules and replaces them with
either direct replacements or extractions from the library.
LooseVersion is extracted into ccmlib.utils.version and dir_util.copy_tree
is replaced by shutil.copytree.
Fixes #537