ccmlib/common: check install_dir/SCYLLA-VERSION-FILE first #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we have some dtests which are marked with "dtest_enterprise" mark. and they deselect themselves if ccm claims that the scylla build is not enterprise. sometimes, we just want to run some of these dtest right from local build, whose SCYLLA-VERSION-FILE is co-located with the scylla executable binary, right under the "install_dir" instead of "install_dir/build/" or somewhere else. so, in this case, ccm would either fail to find the right SCYLLA-VERSION-FILE, or find a wrong one. in this change, we add $install_dir/SCYLLA-VERSION-FILE at the front of the check list, so that ccm can check and use it if this file exists. this should address the pain of developers who want to test from the local build. Signed-off-by: Kefu Chai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have some dtests which are marked with "dtest_enterprise" mark. and they deselect themselves if ccm claims that the scylla build is not enterprise.
sometimes, we just want to run some of these dtest right from local build, whose SCYLLA-VERSION-FILE is co-located with the scylla executable binary, right under the "install_dir" instead of "install_dir/build/" or somewhere else. so, in this case, ccm would either fail to find the right SCYLLA-VERSION-FILE, or find a wrong one.
in this change, we add $install_dir/SCYLLA-VERSION-FILE at the front of the check list, so that ccm can check and use it if this file exists. this should address the pain of developers who want to test from the local build.