Fix Python 3.8 compatibility #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`list[x]` only works from Python 3.9 upwards, not in Python 3.8, which caused CI fails in rust driver and python driver.
Lorak-mmk
force-pushed
the
fix-python38
branch
2 times, most recently
from
7f5b4f8
to
9cb443c
Compare
|
@Lorak-mmk we are not running python-driver integration tests with all versions of python (only the unittests) I'm o.k. with doing 3.8 and up. but we should upgrade CI where it's relevent to to 3.9 at least |
To ensure compatibility and minimize problems for other projects, ccm should be tested with older python too.
fruch
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent change introduced typing that is incompatible with Python < 3.9. There are other Scylla projects relying on CCM (e.g. most drivers) and for some of them this change caused CI failures (as of now - for Rust driver and Python driver).
This PR fixes the problem by making this typing compatible with older Python versions.
It also adds CI that runs on older Python. I wanted it to be 3.6, because that's the oldest version supported by Python driver, but it seems this version can't be installed by
setup-python@v4action, so I bumped it to 3.8