ccmlib/scylla_repository: introduce get_manger_* functions #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
approved these changes
Jul 6, 2023
tchaikov
reviewed
Jul 7, 2023
| Architecture = Literal['x86_64', 'aarch64'] | ||
|
|
||
|
|
||
| def get_manager_latest_reloc_url(branch: str = "master", architecture: Architecture = None) -> str: |
There was a problem hiding this comment.
if we want to enforce type annotations, we might need to, well, enforce it. like
def get_manager_latest_reloc_url(branch: str = "master", architecture: Optional[Architecture] = None) -> str:There was a problem hiding this comment.
It's mostly for documentation now, not going to enforce it with tools.
There was a problem hiding this comment.
yes, if we want to use for document, i think we need to get it right from the very beginning.
tchaikov
reviewed
Jul 7, 2023
tchaikov
reviewed
Jul 7, 2023
tchaikov
reviewed
Jul 7, 2023
tchaikov
reviewed
Jul 7, 2023
fruch
force-pushed
the
manager_versions_lookup
branch
2 times, most recently
from
a6a5092
to
76fa918
Compare
those helper function could be user to retrive scylla manager relocatable packages, that we need in dtest for testing manager, those comes in two flavors: * one to retrive lastet version of of specific branches * one to retrive specific released versions
fruch
force-pushed
the
manager_versions_lookup
branch
from
76fa918
to
11221e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
those helper function could be user to retrive scylla manager relocatable packages, that we need in dtest for testing manager, those comes in two flavors: