Fix marshal tinyint - optimization
#294
Merged
+378
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes: * removed unnecessary checks for `reflect.Int8` and `reflect.Uint8` kinds * makes the right value type in the error of the `EncReflect` function
illia-li
force-pushed
the
il/fix/marshal/optimization_tinyint
branch
from
0529b16
to
23d1f3e
Compare
changes: * double conversion of values has been removed in the functions of single reference values. * the condition `data == nil` moved after the condition `len(data)==0` in the functions of the double references values.
illia-li
force-pushed
the
il/fix/marshal/optimization_tinyint
branch
from
23d1f3e
to
0ae9a24
Compare
dkropachev
reviewed
Oct 8, 2024
dkropachev
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chenges:
1.1. The double conversion of values has been removed in the functions of single reference values.
1.2. The condition
data == nilmoved after the conditionlen(data)==0in the functions of the double references values.EncReflectfunction:2.1. Removed unnecessary checks for
reflect.Int8andreflect.Uint8kinds.2.2. Makes the right value type in the error for
reflect.Stringkind.