Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marshal smallint #284

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

illia-li
Copy link

Fixed for smallint type:

  1. string marshal and unmarshal as nullable.
    1.1. Was: marshals "" - caused an error; unmarshals nil data into "0".
    1.2. Now: marshals and unmarshals nil data - "".
  2. custom string marshals and unmarshals was not supported, now supported.
  3. big.Int marshals was not supported, now supported.
  4. Also was fixed cases when marshal and unmarshal should an error, but currently we does not have a corrupt test suite.

Close issues for smallint:

  1. Marshal, unmarshal. For many cql types unmarshaling data that have bigger len than cql type, do not return an error. #246
  2. Marshal, unmarshal. For many cql types a go string is supported, but not a go custom string #243
  3. Marshal, unmarshal. cql types: tinyint, smallint, int can not be marshaled into go big.Int #244
  4. Marshal, unmarshal. Problems with zero and null data and values. #250

@illia-li illia-li force-pushed the il/fix/marshal/smallint branch 5 times, most recently from f28be63 to 37aa65e Compare October 1, 2024 12:53
@dkropachev dkropachev self-assigned this Oct 1, 2024
@dkropachev dkropachev self-requested a review October 1, 2024 15:26
dkropachev
dkropachev previously approved these changes Oct 1, 2024
@dkropachev dkropachev merged commit fe56500 into scylladb:master Oct 1, 2024
1 check passed
@illia-li illia-li deleted the il/fix/marshal/smallint branch October 4, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants