add marshal corrupt test suite
#278
Conversation
illia-li
force-pushed
the
il/add/marshal_corrupt_test_suite
branch
from
418ae94
to
b1a4ee3
Compare
illia-li
force-pushed
the
il/add/marshal_corrupt_test_suite
branch
2 times, most recently
from
4ecfdd1
to
68b4b03
Compare
illia-li
force-pushed
the
il/add/marshal_corrupt_test_suite
branch
2 times, most recently
from
4943365
to
45d7cf0
Compare
|
sorry for being so picky about commit messages but move all code to internal/tests/serialization is not the best name, |
illia-li
force-pushed
the
il/add/marshal_corrupt_test_suite
branch
from
45d7cf0
to
14bc33e
Compare
Is it better now? |
internal/tests/serialization/set.go
Outdated
| } | ||
|
|
||
| // RunCorruptTest runs tests for cases when the function should an error. | ||
| func (s Set) RunCorruptTest(name string, t *testing.T, marshal func(interface{}) ([]byte, error), unmarshal func([]byte, interface{}) error) { |
There was a problem hiding this comment.
In order to avoid confusiton let's have another structure for these tests or, even split it into two (for negative serialization and deserialization tests), since you already logically split them:
Set -> PositiveSerializationSet
NegativeMarshalSet
NetativeUnmarhsalSet
Feel free to suggest better names for them, or provide contr argument why we hsould not do it.
There was a problem hiding this comment.
:) It's more difficult than just writing code.
`serialization` and `utils` packages are joined and moved to `internal/tests/serialization`
illia-li
force-pushed
the
il/add/marshal_corrupt_test_suite
branch
from
14bc33e
to
6a1a6be
Compare
Changes:
corrupt test suitefor testingmarshal,unmarshalfunctions.corrupt testforsmallintserialization,utilspackages tointernal/tests/serialization