add varint testcases

scylladb · Oct 8, 2024 · 4172b36 · 4172b36
1 parent 4a37774
commit 4172b36
Showing 1 changed file with 149 additions and 24 deletions.
diff --git a/marshal_7_varint_test.go b/marshal_7_varint_test.go
@@ -72,10 +72,29 @@ func TestMarshalVarInt(t *testing.T) {
 		BrokenUnmarshalTypes: brokenCustomStrings,
 	}.Run("zeros", t, marshal, unmarshal)
 
+	serialization.PositiveSet{
+		Data: []byte("\x00\x80\x00\x00\x00\x00\x00\x00\x00"),
+		Values: mod.Values{
+			"9223372036854775808", *big.NewInt(0).Add(big.NewInt(1), big.NewInt(9223372036854775807)),
+		}.AddVariants(mod.All...),
+		BrokenMarshalTypes:   brokenBigStrings,
+		BrokenUnmarshalTypes: brokenBigStrings,
+	}.Run("maxInt64+1", t, marshal, unmarshal)
+
+	serialization.PositiveSet{
+		Data: []byte("\xff\x7f\xff\xff\xff\xff\xff\xff\xff"),
+		Values: mod.Values{
+			"-9223372036854775809", *big.NewInt(0).Add(big.NewInt(-1), big.NewInt(-9223372036854775808)),
+		}.AddVariants(mod.All...),
+		BrokenMarshalTypes:   brokenBigStrings,
+		BrokenUnmarshalTypes: brokenBigStrings,
+	}.Run("minInt64-1", t, marshal, unmarshal)
+
 	serialization.PositiveSet{
 		Data: []byte("\x7f\xff\xff\xff\xff\xff\xff\xff"),
 		Values: mod.Values{
 			int64(9223372036854775807), int(9223372036854775807),
+			uint64(9223372036854775807), uint(9223372036854775807),
 			"9223372036854775807", *big.NewInt(9223372036854775807),
 		}.AddVariants(mod.All...),
 		BrokenMarshalTypes:   brokenCustomStrings,
@@ -96,11 +115,12 @@ func TestMarshalVarInt(t *testing.T) {
 		Data: []byte("\x7f\xff\xff\xff"),
 		Values: mod.Values{
 			int32(2147483647), int64(2147483647), int(2147483647),
+			uint32(2147483647), uint64(2147483647), uint(2147483647),
 			"2147483647", *big.NewInt(2147483647),
 		}.AddVariants(mod.All...),
 		BrokenMarshalTypes:   brokenCustomStrings,
 		BrokenUnmarshalTypes: brokenCustomStrings,
-	}.Run("2147483647", t, marshal, unmarshal)
+	}.Run("maxInt32", t, marshal, unmarshal)
 
 	serialization.PositiveSet{
 		Data: []byte("\x80\x00\x00\x00"),
@@ -110,17 +130,39 @@ func TestMarshalVarInt(t *testing.T) {
 		}.AddVariants(mod.All...),
 		BrokenMarshalTypes:   brokenCustomStrings,
 		BrokenUnmarshalTypes: brokenCustomStrings,
-	}.Run("-2147483648", t, marshal, unmarshal)
+	}.Run("minInt32", t, marshal, unmarshal)
+
+	serialization.PositiveSet{
+		Data: []byte("\x00\x80\x00\x00\x00"),
+		Values: mod.Values{
+			int64(2147483648), int(2147483648),
+			uint32(2147483648), uint64(2147483648), uint(2147483648),
+			"2147483648", *big.NewInt(2147483648),
+		}.AddVariants(mod.All...),
+		BrokenMarshalTypes:   brokenCustomStrings,
+		BrokenUnmarshalTypes: brokenCustomStrings,
+	}.Run("maxInt32+1", t, marshal, unmarshal)
+
+	serialization.PositiveSet{
+		Data: []byte("\xff\x7f\xff\xff\xff"),
+		Values: mod.Values{
+			int64(-2147483649), int(-2147483649),
+			"-2147483649", *big.NewInt(-2147483649),
+		}.AddVariants(mod.All...),
+		BrokenMarshalTypes:   brokenCustomStrings,
+		BrokenUnmarshalTypes: brokenCustomStrings,
+	}.Run("minInt32-1", t, marshal, unmarshal)
 
 	serialization.PositiveSet{
 		Data: []byte("\x7f\xff"),
 		Values: mod.Values{
 			int16(32767), int32(32767), int64(32767), int(32767),
+			uint16(32767), uint32(32767), uint64(32767), uint(32767),
 			"32767", *big.NewInt(32767),
 		}.AddVariants(mod.All...),
 		BrokenMarshalTypes:   brokenCustomStrings,
 		BrokenUnmarshalTypes: brokenCustomStrings,
-	}.Run("32767", t, marshal, unmarshal)
+	}.Run("maxInt16", t, marshal, unmarshal)
 
 	serialization.PositiveSet{
 		Data: []byte("\x80\x00"),
@@ -130,17 +172,39 @@ func TestMarshalVarInt(t *testing.T) {
 		}.AddVariants(mod.All...),
 		BrokenMarshalTypes:   brokenCustomStrings,
 		BrokenUnmarshalTypes: brokenCustomStrings,
-	}.Run("-32768", t, marshal, unmarshal)
+	}.Run("minInt16", t, marshal, unmarshal)
+
+	serialization.PositiveSet{
+		Data: []byte("\x00\x80\x00"),
+		Values: mod.Values{
+			int32(32768), int64(32768), int(32768),
+			uint16(32768), uint32(32768), uint64(32768), uint(32768),
+			"32768", *big.NewInt(32768),
+		}.AddVariants(mod.All...),
+		BrokenMarshalTypes:   brokenCustomStrings,
+		BrokenUnmarshalTypes: brokenCustomStrings,
+	}.Run("maxInt16+1", t, marshal, unmarshal)
+
+	serialization.PositiveSet{
+		Data: []byte("\xff\x7f\xff"),
+		Values: mod.Values{
+			int32(-32769), int64(-32769), int(-32769),
+			"-32769", *big.NewInt(-32769),
+		}.AddVariants(mod.All...),
+		BrokenMarshalTypes:   brokenCustomStrings,
+		BrokenUnmarshalTypes: brokenCustomStrings,
+	}.Run("minInt16-1", t, marshal, unmarshal)
 
 	serialization.PositiveSet{
 		Data: []byte("\x7f"),
 		Values: mod.Values{
 			int8(127), int16(127), int32(127), int64(127), int(127),
+			uint8(127), uint16(127), uint32(127), uint64(127), uint(127),
 			"127", *big.NewInt(127),
 		}.AddVariants(mod.All...),
 		BrokenMarshalTypes:   brokenCustomStrings,
 		BrokenUnmarshalTypes: brokenCustomStrings,
-	}.Run("127", t, marshal, unmarshal)
+	}.Run("maxInt8", t, marshal, unmarshal)
 
 	serialization.PositiveSet{
 		Data: []byte("\x80"),
@@ -150,53 +214,114 @@ func TestMarshalVarInt(t *testing.T) {
 		}.AddVariants(mod.All...),
 		BrokenMarshalTypes:   brokenCustomStrings,
 		BrokenUnmarshalTypes: brokenCustomStrings,
-	}.Run("-128", t, marshal, unmarshal)
+	}.Run("minInt8", t, marshal, unmarshal)
+
+	serialization.PositiveSet{
+		Data: []byte("\x00\x80"),
+		Values: mod.Values{
+			int16(128), int32(128), int64(128), int(128),
+			uint8(128), uint16(128), uint32(128), uint64(128), uint(128),
+			"128", *big.NewInt(128),
+		}.AddVariants(mod.All...),
+		BrokenMarshalTypes:   brokenCustomStrings,
+		BrokenUnmarshalTypes: brokenCustomStrings,
+	}.Run("maxInt8+1", t, marshal, unmarshal)
+
+	serialization.PositiveSet{
+		Data: []byte("\xff\x7f"),
+		Values: mod.Values{
+			int16(-129), int32(-129), int64(-129), int(-129),
+			"-129", *big.NewInt(-129),
+		}.AddVariants(mod.All...),
+		BrokenMarshalTypes:   brokenCustomStrings,
+		BrokenUnmarshalTypes: brokenCustomStrings,
+	}.Run("minInt8-1", t, marshal, unmarshal)
 
 	serialization.PositiveSet{
 		Data: []byte("\x00\xff"),
 		Values: mod.Values{
 			uint8(255), uint16(255), uint32(255), uint64(255), uint(255),
+			int16(255), int32(255), int64(255), int(255),
+			"255", *big.NewInt(255),
+		}.AddVariants(mod.All...),
+		BrokenMarshalTypes:   brokenCustomStrings,
+		BrokenUnmarshalTypes: brokenCustomStrings,
+	}.Run("maxUint8", t, marshal, unmarshal)
+
+	serialization.PositiveSet{
+		Data: []byte("\x01\x00"),
+		Values: mod.Values{
+			uint16(256), uint32(256), uint64(256), uint(256),
+			int16(256), int32(256), int64(256), int(256),
+			"256", *big.NewInt(256),
 		}.AddVariants(mod.All...),
-	}.Run("255", t, marshal, unmarshal)
+		BrokenMarshalTypes:   brokenCustomStrings,
+		BrokenUnmarshalTypes: brokenCustomStrings,
+	}.Run("maxUint8+1", t, marshal, unmarshal)
 
 	serialization.PositiveSet{
 		Data: []byte("\x00\xff\xff"),
 		Values: mod.Values{
 			uint16(65535), uint32(65535), uint64(65535), uint(65535),
+			int32(65535), int64(65535), int(65535),
+			"65535", *big.NewInt(65535),
+		}.AddVariants(mod.All...),
+		BrokenMarshalTypes:   brokenCustomStrings,
+		BrokenUnmarshalTypes: brokenCustomStrings,
+	}.Run("maxUint16", t, marshal, unmarshal)
+
+	serialization.PositiveSet{
+		Data: []byte("\x01\x00\x00"),
+		Values: mod.Values{
+			uint32(65536), uint64(65536), uint(65536),
+			int32(65536), int64(65536), int(65536),
+			"65536", *big.NewInt(65536),
 		}.AddVariants(mod.All...),
-	}.Run("65535", t, marshal, unmarshal)
+		BrokenMarshalTypes:   brokenCustomStrings,
+		BrokenUnmarshalTypes: brokenCustomStrings,
+	}.Run("maxUint16+1", t, marshal, unmarshal)
 
 	serialization.PositiveSet{
 		Data: []byte("\x00\xff\xff\xff\xff"),
 		Values: mod.Values{
 			uint32(4294967295), uint64(4294967295), uint(4294967295),
+			int64(4294967295), int(4294967295),
+			"4294967295", *big.NewInt(4294967295),
 		}.AddVariants(mod.All...),
-	}.Run("4294967295", t, marshal, unmarshal)
+		BrokenMarshalTypes:   brokenCustomStrings,
+		BrokenUnmarshalTypes: brokenCustomStrings,
+	}.Run("maxUint32", t, marshal, unmarshal)
 
 	serialization.PositiveSet{
-		Data: []byte("\x00\xff\xff\xff\xff\xff\xff\xff\xff"),
+		Data: []byte("\x01\x00\x00\x00\x00"),
 		Values: mod.Values{
-			uint64(18446744073709551615), uint(18446744073709551615),
+			uint64(4294967296), uint(4294967296),
+			int64(4294967296), int(4294967296),
+			"4294967296", *big.NewInt(4294967296),
 		}.AddVariants(mod.All...),
-		BrokenMarshalTypes:   brokenUints,
-		BrokenUnmarshalTypes: brokenUints,
-	}.Run("max_uint", t, marshal, unmarshal)
+		BrokenMarshalTypes:   brokenCustomStrings,
+		BrokenUnmarshalTypes: brokenCustomStrings,
+	}.Run("maxUint32+1", t, marshal, unmarshal)
+
+	bigMaxUint64 := new(big.Int)
+	bigMaxUint64.SetString("18446744073709551615", 10)
 
 	serialization.PositiveSet{
-		Data: []byte("\x00\x80\x00\x00\x00\x00\x00\x00\x00"),
+		Data: []byte("\x00\xff\xff\xff\xff\xff\xff\xff\xff"),
 		Values: mod.Values{
-			"9223372036854775808", *big.NewInt(0).Add(big.NewInt(1), big.NewInt(9223372036854775807)),
+			uint64(18446744073709551615), uint(18446744073709551615),
+			"18446744073709551615", *bigMaxUint64,
 		}.AddVariants(mod.All...),
-		BrokenMarshalTypes:   brokenBigStrings,
-		BrokenUnmarshalTypes: brokenBigStrings,
-	}.Run("maxInt64+1", t, marshal, unmarshal)
+		BrokenMarshalTypes:   append(brokenUints, brokenBigStrings...),
+		BrokenUnmarshalTypes: append(brokenUints, brokenBigStrings...),
+	}.Run("maxUint64", t, marshal, unmarshal)
 
 	serialization.PositiveSet{
-		Data: []byte("\xff\x7f\xff\xff\xff\xff\xff\xff\xff"),
+		Data: []byte("\x01\x00\x00\x00\x00\x00\x00\x00\x00"),
 		Values: mod.Values{
-			"-9223372036854775809", *big.NewInt(0).Add(big.NewInt(-1), big.NewInt(-9223372036854775808)),
+			"18446744073709551616", *big.NewInt(0).Add(bigMaxUint64, big.NewInt(1)),
 		}.AddVariants(mod.All...),
-		BrokenMarshalTypes:   brokenBigStrings,
-		BrokenUnmarshalTypes: brokenBigStrings,
-	}.Run("minInt64-1", t, marshal, unmarshal)
+		BrokenMarshalTypes:   append(brokenUints, brokenBigStrings...),
+		BrokenUnmarshalTypes: append(brokenUints, brokenBigStrings...),
+	}.Run("maxUint64+1", t, marshal, unmarshal)
 }