Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix the reference to router.bfd.disable #4581

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

jiceatscion
Copy link
Contributor

router.bfd.disabled -> router.bfd.disable

Fixes #4537

router.bfd.disabled -> router.bfd.disable
@jiceatscion
Copy link
Contributor Author

This change is Reviewable

@jiceatscion jiceatscion requested a review from a team July 18, 2024 11:25
Copy link
Contributor

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jiceatscion)

@matzf matzf changed the title documentation: fix the reference to router.bfd.disable doc: fix the reference to router.bfd.disable Jul 18, 2024
Copy link
Contributor

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No wait, doc build fails, it seems this is referenced somewhere: doc/manuals/common.rst:297: WARNING: unknown option: 'router-conf-toml disabled'

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jiceatscion)

Copy link
Contributor

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jiceatscion)

@jiceatscion jiceatscion merged commit bfcdfbf into scionproto:master Jul 18, 2024
5 checks passed
@jiceatscion jiceatscion deleted the fix4537 branch July 18, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Router Config: Typo in BFD Disable(d)
2 participants