Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: add check for PR title #4574

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

matzf
Copy link
Contributor

@matzf matzf commented Jul 15, 2024

Github workflow to check that the PR title follows the contribution guidelines:

  • Starts with <subsystem>:
  • Uses lowercase letters for subject line (and does not end with a period)

Could also be done in buildkite, but github action seems appropriate.

@jiceatscion
Copy link
Contributor

This change is Reviewable

@matzf matzf changed the title github: add check for PR title Add check for PR title Jul 15, 2024
Copy link
Contributor

@jiceatscion jiceatscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@matzf matzf changed the title Add check for PR title github: Add check for PR title Jul 15, 2024
@matzf matzf changed the title github: Add check for PR title github: add check for PR title. Jul 15, 2024
@matzf matzf changed the title github: add check for PR title. github: add check for PR title Jul 15, 2024
@matzf matzf marked this pull request as ready for review July 15, 2024 12:19
Copy link
Contributor

@jiceatscion jiceatscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matzf)

@matzf matzf merged commit ce54172 into scionproto:master Jul 16, 2024
5 checks passed
@matzf matzf deleted the github-pr-check-title branch July 16, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants