Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vite #1882

Merged
merged 26 commits into from
Oct 24, 2022
Merged

Vite #1882

merged 26 commits into from
Oct 24, 2022

Commits on Oct 13, 2022

  1. add vite-rails gem

    @jrochkind
    jrochkind committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    ba53a96 View commit details
    Browse the repository at this point in the history

  2. install vite-rails 

        bundle exec vite install

But we changed things over to generic app/frontend, not app/javascripts that the install script wanted to use seeing we already had webpacker. We want to keep them separate.

Also we have not committed the Procfile.dev for now, I don't think we'll use foreman.
    @jrochkind
    jrochkind committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    f09e7cc View commit details
    Browse the repository at this point in the history

  3. move admin pack from webpacker to vite

    @jrochkind
    jrochkind committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    a3c0c6c View commit details
    Browse the repository at this point in the history

  4. move lazysizes JS entrypoint over to vite

    @jrochkind
    jrochkind committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    fd1d6b6 View commit details
    Browse the repository at this point in the history

  5. reposition lazysizes entrypoint per better reading of lazysizes doc s… 

    …uggestions
    @jrochkind
    jrochkind committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    e3157ed View commit details
    Browse the repository at this point in the history

  6. move entire 'application.js' entrypoint from webpacker to vite

    @jrochkind
    jrochkind committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    51766d6 View commit details
    Browse the repository at this point in the history

  7. entirely remove Webpacker and Webpack -- we use vite now

    @jrochkind
    jrochkind committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    3a35f51 View commit details
    Browse the repository at this point in the history

  8. restore accidentally removed defer on application entrypoint load

    @jrochkind
    jrochkind committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    328b3b2 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. README updated for vite transition

    @jrochkind
    jrochkind committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    a3c8ce7 View commit details
    Browse the repository at this point in the history

  2. remove fetch and promise polyfills for IE, we no longer support IE

    @jrochkind
    jrochkind committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    f788221 View commit details
    Browse the repository at this point in the history

  3. remove polyfill for 'closest', no longer required by any browser we s… 

    …upport, we think
    @jrochkind
    jrochkind committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    07f7386 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. Make vite create .gz (and brotli) alternatives for built assets 

    In our heroku deployment, our Rails app is directly serving assets (then cached by cloudfront).  Under sprockets/webpacker, .gz alternates were created on asset build. And Rails will then automatically use these to serve content-encoded gzip content to clients which advertise accepting that.

We lost that in initial vite migration, resulting in performance loss in deployed apps, as clients were not getting compressed .js and .css. This should fix that.

ElMassimo/vite_ruby#281
    @jrochkind
    jrochkind committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    0fb11a1 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1890 from sciencehistory/remove_polyfills_for_ie 

    Remove browser JS polyfills no longer required for current supported browsers
    @eddierubeiz
    eddierubeiz authored Oct 18, 2022
    Configuration menu
    Copy the full SHA
    6cf1a3d View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1896 from sciencehistory/vite_gzip 

    Make vite create .gz (and brotli) alternatives for built assets
    @eddierubeiz
    eddierubeiz authored Oct 18, 2022
    Configuration menu
    Copy the full SHA
    ffe852a View commit details
    Browse the repository at this point in the history

  4. move jquery and popper to be loaded via vite

    @jrochkind
    jrochkind committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    f14c37c View commit details
    Browse the repository at this point in the history

  5. move bootstrap JS to vite from sprockets

    @jrochkind
    jrochkind committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    c041a6c View commit details
    Browse the repository at this point in the history

  6. move rails-ujs from sprockets to vite

    @jrochkind
    jrochkind committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    a267d0c View commit details
    Browse the repository at this point in the history

  7. move cocoon JS over to vite

    @jrochkind
    jrochkind committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    9574f6e View commit details
    Browse the repository at this point in the history

  8. avoid browse_everything doing a double-include of bootstrap

    @jrochkind
    jrochkind committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    a4165f9 View commit details
    Browse the repository at this point in the history

  9. update comment header in sprockets application.js, for move to vite

    @jrochkind
    jrochkind committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    467c54d View commit details
    Browse the repository at this point in the history

  10. remove actioncable from sprockets entirely 

    Don't move it over to vite. We weren't using it. if we ever want to use it, we'll have to figure out how to add it back in via vite
    @jrochkind
    jrochkind committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    973c6c4 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Move browse_everything sprockets JS to admin layout only 

    With weird workaround to prevent Blacklight sprockets-included JS from triggering strict mode, which breaks current version of blacklight_range_limit JS
    @jrochkind
    jrochkind committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    83810f1 View commit details
    Browse the repository at this point in the history

  2. have vite/rollup chunk video.js separately

    @jrochkind
    jrochkind committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    4b55c69 View commit details
    Browse the repository at this point in the history

  3. enable source maps in dev autoBuild 

    Unclear exactly what default is or how to turn off in prod. ElMassimo/vite_ruby#285
    @jrochkind
    jrochkind committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    a329f42 View commit details
    Browse the repository at this point in the history

  4. update README for moving most JS to vite -- but not yet blacklight

    @jrochkind
    jrochkind committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    1a68fc4 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #1889 from sciencehistory/vite_move_more_js_over 

    Move as much JS as possible from sprockets to vite
    @eddierubeiz
    eddierubeiz authored Oct 20, 2022
    Configuration menu
    Copy the full SHA
    759a5b9 View commit details
    Browse the repository at this point in the history