Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Finalize named tuples" to 3.6.0 #21773

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Backport "Finalize named tuples" to 3.6.0 #21773

merged 4 commits into from
Oct 15, 2024

Commits on Oct 15, 2024

  1. Use the NamedTuple type ops for the result types of the term ops

    @EugeneFlesselle @WojciechMazur
    EugeneFlesselle authored and WojciechMazur committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ef44166 View commit details
    Browse the repository at this point in the history

  2. Drop asInstanceOf from the NamedTuple term ops where possible

    @EugeneFlesselle @WojciechMazur
    EugeneFlesselle authored and WojciechMazur committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0b00f25 View commit details
    Browse the repository at this point in the history

  3. Fix typos

    @EugeneFlesselle @WojciechMazur
    EugeneFlesselle authored and WojciechMazur committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    006879b View commit details
    Browse the repository at this point in the history

  4. Add an explicit type instantiation in NamedTuple.map 

    To avoid triggering a deep subtype comparison
needed for the inference of the higher-kinded type parameter.
    @EugeneFlesselle @WojciechMazur
    EugeneFlesselle authored and WojciechMazur committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0743478 View commit details
    Browse the repository at this point in the history