Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code rendering error in givens.md #21751

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix code rendering error in givens.md #21751

merged 1 commit into from
Oct 11, 2024

Conversation

bishabosha
Copy link
Member

an extra code fence was added, so the bottom of the page is incorrectly rendered

an extra code fence was added, so the bottom of the page is incorrectly rendered
@bishabosha bishabosha added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Oct 11, 2024
@bishabosha
Copy link
Member Author

Back port to 3.6?

@bishabosha bishabosha merged commit 5e7ab15 into main Oct 11, 2024
49 of 50 checks passed
@bishabosha bishabosha deleted the bishabosha-patch-1 branch October 11, 2024 06:27
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Oct 15, 2024
@WojciechMazur WojciechMazur added this to the 3.6.0 milestone Oct 15, 2024
WojciechMazur added a commit that referenced this pull request Oct 15, 2024
Backports #21751 to 3.6.0-RC1

[skip ci]

Co-authored-by: Jamie Thompson <[email protected]>
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:done This PR was successfully backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants